Skip to content

Conversation

@ohakutsu
Copy link
Member

What

  • Change CONTACT METHOD to Qiita Support at CODE_OF_CONDUCT.
  • Change README for Qiita Marker.

Refs

@ohakutsu ohakutsu self-assigned this Nov 11, 2021
@ohakutsu ohakutsu requested review from kskwtnk and kyntk November 11, 2021 07:17
Copy link
Member

@kskwtnk kskwtnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content was good, but I have a comment about the formatting.

Comment on lines +6 to +11
We as members, contributors, and leaders pledge to make participation in our
community a harassment-free experience for everyone, regardless of age, body
size, visible or invisible disability, ethnicity, sex characteristics, gender
identity and expression, level of experience, education, socio-economic status,
nationality, personal appearance, race, religion, or sexual identity
and orientation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are deliberate line breaks throughout, is this a change made by the formatter?

If so, you can leave the code as it is now, but if not, it's better not to break lines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xrxoxcxox
The markdown format of Contribution Covenant is used as is. Therefore, the format looks like that.

The markdown format of Contribution Covenant can be found here.
https://www.contributor-covenant.org/version/2/0/code_of_conduct/code_of_conduct.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ohakutsu

I see. Then please keep the current code.

Comment on lines +129 to +133
[homepage]: https://www.contributor-covenant.org
[v2.0]: https://www.contributor-covenant.org/version/2/0/code_of_conduct.html
[Mozilla CoC]: https://github.com/mozilla/diversity
[FAQ]: https://www.contributor-covenant.org/faq
[translations]: https://www.contributor-covenant.org/translations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since none of these links are used more than once, I thought the same formatting as line 63 would be fine
That is, write it as follows

[text](URL)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also the same as #2 (comment).

@kskwtnk kskwtnk self-requested a review November 11, 2021 08:33
Copy link
Member

@kskwtnk kskwtnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@kyntk kyntk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ohakutsu ohakutsu merged commit aa728cd into main Nov 12, 2021
@mziyut mziyut deleted the change-readme-and-code-of-conduct branch March 4, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants